WebSVN – HelenOS – Diff – //trunk/kernel/arch/ia32/src/asm.S

 # THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+#
 ## very low and hardware-level functions
-# Mask for interrupts 0 - 31 (bits 0 - 31) where 0 means that int has no error word
+# Mask for interrupts 0 - 31 (bits 0 - 31) where 0 means that int has no error
-# and 1 means interrupt with error word
+# word and 1 means interrupt with error word
-#define ERROR_WORD_INTERRUPT_LIST 0x00027D00
+#define ERROR_WORD_INTERRUPT_LIST 0x00027d00
 .text
 .global paging_on
 .global enable_l_apic_in_msr
  * @return MEMCPY_SRC(%esp) on success and 0 on failure.
  */
 memcpy:
 memcpy_from_uspace:
 memcpy_to_uspace:
-	movl %edi, %edx				/* save %edi */
+	movl %edi, %edx			/* save %edi */
-	movl %esi, %eax				/* save %esi */
+	movl %esi, %eax			/* save %esi */
 	movl MEMCPY_SIZE(%esp), %ecx
-	shrl $2, %ecx				/* size / 4 */
+	shrl $2, %ecx			/* size / 4 */
 	movl MEMCPY_DST(%esp), %edi
 	movl MEMCPY_SRC(%esp), %esi
-	rep movsl				/* copy as much as possible word by word */
+	rep movsl			/* copy whole words */
 	movl MEMCPY_SIZE(%esp), %ecx
-	andl $3, %ecx				/* size % 4 */
+	andl $3, %ecx			/* size % 4 */
 	jz 0f
-	rep movsb				/* copy the rest byte by byte */
+	rep movsb			/* copy the rest byte by byte */
 :
 	movl %edx, %edi
 	movl %eax, %esi
-	movl MEMCPY_SRC(%esp), %eax		/* MEMCPY_SRC(%esp), success */
+	movl MEMCPY_SRC(%esp), %eax	/* MEMCPY_SRC(%esp), success */
 	ret
 /*
  * We got here from as_page_fault() after the memory operations
  * above had caused a page fault.
  */
 memcpy_from_uspace_failover_address:
 memcpy_to_uspace_failover_address:
 	movl %edx, %edi
 	movl %eax, %esi
-	xorl %eax, %eax				/* return 0, failure */
+	xorl %eax, %eax			/* return 0, failure */
 	ret
 ## Turn paging on
+#
 # Enable paging and write-back caching in CR0.
+#
 paging_on:
-	movl %cr0,%edx
+	movl %cr0, %edx
-	orl $(1<<31),%edx		# paging on
+	orl $(1 << 31), %edx		# paging on
-	andl $~((1<<30)|(1<<29)),%edx	# clear Cache Disable and not Write Though
+	# clear Cache Disable and not Write Though
+	andl $~((1 << 30) | (1 << 29)), %edx
 	movl %edx,%cr0
 	jmp 0f
 :
 	ret
 ## Enable local APIC
+#
 # Enable local APIC in MSR.
+#
 enable_l_apic_in_msr:
-	push %eax
 	movl $0x1b, %ecx
 	rdmsr
-	orl $(1<<11),%eax
+	orl $(1 << 11), %eax
-	orl $(0xfee00000),%eax
+	orl $(0xfee00000), %eax
 	wrmsr
-	pop %eax
 	ret
 # Clear nested flag
 # overwrites %ecx
 .macro CLEAR_NT_FLAG
 	pushfl
 	pop %ecx
-	and $0xffffbfff,%ecx
+	and $0xffffbfff, %ecx
 	push %ecx
 	popfl
 .endm
 ## Declare interrupt handlers
 # and call exc_dispatch().
+#
 #define INTERRUPT_ALIGN 64
 .macro handler i n
-.ifeq \i-0x30     # Syscall handler
+.ifeq \i - 0x30     # Syscall handler
-	push %ds
+	pushl %ds
-	push %es
+	pushl %es
-	push %fs
+	pushl %fs
-	push %gs
+	pushl %gs
+	#
-	# Push arguments on stack
+	# Push syscall arguments onto the stack
+	#
+	# NOTE: The idea behind the order of arguments passed in registers is to
+	#	use all scratch registers first and preserved registers next.
+	#	An optimized libc syscall wrapper can make use of this setup.
+	#
+	pushl %eax
+	pushl %ebp
-	push %edi
+	pushl %edi
-	push %esi
+	pushl %esi
-	push %edx
+	pushl %ebx
-	push %ecx
+	pushl %ecx
-	push %eax
+	pushl %edx
 	# we must fill the data segment registers
-	movw $16,%ax
+	movw $16, %ax
-	movw %ax,%ds
+	movw %ax, %ds
-	movw %ax,%es
+	movw %ax, %es
 	sti
-	call syscall_handler   # syscall_handler(ax,cx,dx,si,di)
+	# syscall_handler(edx, ecx, ebx, esi, edi, ebp, eax)
+	call syscall_handler
 	cli
-	addl $20, %esp         # clean-up of parameters
+	addl $28, %esp         # clean-up of parameters
-	pop %gs
+	popl %gs
-	pop %fs
+	popl %fs
-	pop %es
+	popl %es
-	pop %ds
+	popl %ds
 	CLEAR_NT_FLAG
 	iret
 .else
 	/*
 	 * This macro distinguishes between two versions of ia32 exceptions.
 	 * One version has error word and the other does not have it.
 	 * The latter version fakes the error word on the stack so that the
 	 * handlers and istate_t can be the same for both types.
 	 */
-	.iflt \i-32
+	.iflt \i - 32
 		.if (1 << \i) & ERROR_WORD_INTERRUPT_LIST
 			/*
 			 * With error word, do nothing
 			 */
                 .else
                  * Version without error word,
                  */
 		subl $4, %esp
 	.endif
-	push %ds
+	pushl %ds
-	push %es
+	pushl %es
-	push %fs
+	pushl %fs
-	push %gs
+	pushl %gs
 #ifdef CONFIG_DEBUG_ALLREGS
-	push %ebx
+	pushl %ebx
-	push %ebp
+	pushl %ebp
-	push %edi
+	pushl %edi
-	push %esi
+	pushl %esi
 #else
-	sub $16, %esp
+	subl $16, %esp
 #endif
-	push %edx
+	pushl %edx
-	push %ecx
+	pushl %ecx
-	push %eax
+	pushl %eax
 	# we must fill the data segment registers
-	movw $16,%ax
+	movw $16, %ax
-	movw %ax,%ds
+	movw %ax, %ds
-	movw %ax,%es
+	movw %ax, %es
 	pushl %esp          # *istate
 	pushl $(\i)         # intnum
 	call exc_dispatch   # excdispatch(intnum, *istate)
-	addl $8,%esp        # Clear arguments from stack
+	addl $8, %esp       # Clear arguments from stack
 	CLEAR_NT_FLAG # Modifies %ecx
-	pop %eax
+	popl %eax
-	pop %ecx
+	popl %ecx
-	pop %edx
+	popl %edx
 #ifdef CONFIG_DEBUG_ALLREGS
-	pop %esi
+	popl %esi
-	pop %edi
+	popl %edi
-	pop %ebp
+	popl %ebp
-	pop %ebx
+	popl %ebx
 #else
-	add $16, %esp
+	addl $16, %esp
 #endif
-	pop %gs
+	popl %gs
-	pop %fs
+	popl %fs
-	pop %es
+	popl %es
-	pop %ds
+	popl %ds
-	addl $4,%esp	# Skip error word, no matter whether real or fake.
+	addl $4, %esp	# Skip error word, no matter whether real or fake.
 	iret
 .endif
 	.align INTERRUPT_ALIGN
-	.if (\n-\i)-1
+	.if (\n- \i) - 1
-	handler "(\i+1)",\n
+	handler "(\i + 1)", \n
 	.endif
 .endm
 # keep in sync with pm.h !!!
-IDT_ITEMS=64
+IDT_ITEMS = 64
 .align INTERRUPT_ALIGN
 interrupt_handlers:
 h_start:
 	handler 0 IDT_ITEMS
 h_end:
 .data
 .global interrupt_handler_size
-interrupt_handler_size: .long (h_end-h_start)/IDT_ITEMS
+interrupt_handler_size: .long (h_end - h_start) / IDT_ITEMS

Subversion Repositories HelenOS

(root)//trunk/kernel/arch/ia32/src/asm.S – Rev 2071 → 2613