Subversion Repositories HelenOS

Rev

Go to most recent revision | Show changed files | Directory listing | RSS feed

Filtering Options

Rev Age Author Path Log message Diff
2470 6159 d 20 h jermar /trunk/ Fix a double-free recently introduced in revision r2436.
Add a comment clarifying the life-cycle of the kernel_uarg structure.

Comment out the freeing of userspace thread stack while still running on it.
This should be fixed by implementing userspace version of thread_join().
 
2451 6168 d 22 h jermar /trunk/kernel/generic/ JoinMe -> Lingering  
2446 6172 d 2 h jermar /trunk/kernel/generic/ More efficient and simpler task termination.

Based on the assumption, that after its creation, only the task itself can create more threads for itself,
the last thread with userspace context to execute thread_exit() will perform futex and IPC cleanup. When
the task has no threads, it is destroyed. Both the cleanup and destruction is controlled by reference
counting.

As for userspace threads, even though there could be a global garbage collector for joining threads, it is
much simpler if the uinit thread detaches itself before switching to userspace.

task_kill() is now an idempotent operation. It just instructs the threads within a task to exit.

Change in the name of a thread state: Undead -> JoinMe.
 
2440 6172 d 20 h jermar /trunk/kernel/generic/ Fix the problem with sys_thread_create() by splitting the create and attach functionality of
thread_create(). Now it is possible to specify a flag that will cause thread_create() to only allocate and
initialize the thread structure. A call to thread_attach() will make the thread visible to the system.
This arrangement makes it easier to undo creation of a thread in case of a failure in sys_thread_create().
 
2436 6173 d 22 h jermar /trunk/ Fix two memory leaks.

In kernel, kernel_uarg structure needs to be deallocated when a thread
with userspace context is destroyed.

In userspace, the return value of the SYS_THREAD_CREATE must be checked
for error conditions and in case of error, uarg and stack must be freed
up.
 
2310 6196 d 23 h jermar /trunk/kernel/generic/ Cleanup the waitq_wakeup() interface.
Replace numeric constants (i.e. 0)
and boolean constants (i.e. false) with
more readable WAKEUP_FIRST. Also change the
type of the second argument of waitq_wakeup()
to a newly introduced type wakeup_mode_t.

Fix behaviour of waitq_wakeup() in case
that WAKEUP_ALL semantics is required
but no threads are sleeping in the wait
queue. This is a similar fix to that of
Jan Hudecek committed in the RCU branch,
but, IMHO, is more straightforward and
also doesn't eat up previous missed
wakeups.
 
2285 6209 d 7 h jermar /trunk/kernel/generic/src/proc/ Formatting and indentation fixes.  
2268 6215 d 22 h jermar /trunk/kernel/generic/ Document and assert proper usage of THREAD_FLAG_WIRED.
Original patch by Jan Hudecek.
 
2229 6225 d 4 h jermar /trunk/ Revert some of the changes introduced in revision 2209.
I think it is not correct to remove serialization of pseudo threads in printf_core.c.
With thread-level futex serialization, several pseudo threads running in one thread could easily deadlock
the task.

Add a dedicated futex serialization to thread1.c test only.
 
2227 6225 d 11 h decky /trunk/kernel/ start shutdown infrastructure  
2216 6226 d 22 h decky /trunk/ make thread ID 64 bit (task ID is 64 bit already)
cleanup thread syscalls
 
2187 6228 d 5 h decky /trunk/kernel/generic/ add syscall for getting current thread ID  
2183 6229 d 1 h jermar /trunk/kernel/generic/ Continue to de-oversynchronize the kernel.
- replace as->refcount with an atomic counter; accesses to this
reference counter are not to be done when the as->lock mutex is held;
this gets us rid of mutex_lock_active();

Remove the possibility of a deadlock between TLB shootdown and asidlock.
- get rid of mutex_lock_active() on as->lock
- when locking the asidlock spinlock, always do it conditionally and with
preemption disabled; in the unsuccessful case, enable interrupts and try again
- there should be no deadlock between TLB shootdown and the as->lock mutexes
- PLEASE REVIEW !!!

Add DEADLOCK_PROBE's to places where we have spinlock_trylock() loops.
 
2118 6288 d 3 h decky /trunk/kernel/generic/src/ explicit typecast, fix signed/unsigned comparison  
2109 6289 d 6 h jermar /trunk/kernel/generic/ Revert thread_interrupt_sleep() to waitq_interrupt_sleep().
I'd prefer that this, IMO, waitq related stuff stays together.
 
2089 6296 d 4 h decky /trunk/ huge type system cleanup
remove cyclical type dependencies across multiple header files
many minor coding style fixes
 
2087 6297 d 0 h jermar /trunk/kernel/ Indentaion and formatting changes even Martin will like :-)  
2071 6306 d 21 h jermar /trunk/ (c) versus (C)  
2068 6314 d 4 h jermar /trunk/kernel/ Formatting and indentation fixes.  
2067 6317 d 3 h jermar /trunk/kernel/ More formatting changes.  

Show All