Subversion Repositories HelenOS

Rev

Go to most recent revision | Hide changed files | Details | Compare with Previous | Blame | RSS feed

Filtering Options

Rev Age Author Path Log message Diff Changes
2618 6076 d 16 h jermar /trunk/ Modify asynchronous IPC to make use of all six syscall arguments. The preferred
means of asynchronous communication is now via the set of ipc_call_async_m()
macros, where m is the number of payload arguments passed to the kernel. These
macros will automatically decide between the fast and the universal slow version
of ipc_call_async.
 
/trunk/kernel/generic/include/ipc/sysipc.h
/trunk/kernel/generic/include/syscall/syscall.h
/trunk/kernel/generic/src/ipc/sysipc.c
/trunk/kernel/generic/src/syscall/syscall.c
/trunk/uspace/app/tester/ipc/send_async.c
/trunk/uspace/lib/libc/generic/ipc.c
/trunk/uspace/lib/libc/include/ipc/ipc.h
/trunk/uspace/srv/console/console.c
2617 6077 d 8 h jermar /trunk/kernel/generic/src/ipc/ STRUCT_TO_USPACE may fail in sys_ipc_call_sync_fast.  
/trunk/kernel/generic/src/ipc/sysipc.c
2615 6077 d 13 h jermar /trunk/ Modify synchronous IPC to make use of all six syscall arguments. The preferred
means of synchronous communication is now via the set of ipc_call_sync_m_n()
macros, where m is the number of payload arguments passed to the kernel and n is
the number of return values. These macros will automatically decide between the
fast and the universal slow version of ipc_call_sync.
 
/trunk/kernel/generic/include/ipc/sysipc.h
/trunk/kernel/generic/include/syscall/syscall.h
/trunk/kernel/generic/src/ipc/sysipc.c
/trunk/kernel/generic/src/syscall/syscall.c
/trunk/uspace/app/klog/klog.c
/trunk/uspace/app/tester/ipc/send_sync.c
/trunk/uspace/lib/libc/generic/ipc.c
/trunk/uspace/lib/libc/generic/time.c
/trunk/uspace/lib/libc/include/ipc/ipc.h
/trunk/uspace/srv/fs/fat/fat.c
2605 6080 d 9 h jermar /trunk/ Start support for six syscall arguments.
This breaks all architectures.
 
/trunk/kernel/generic/include/syscall/syscall.h
/trunk/kernel/generic/src/syscall/syscall.c
/trunk/uspace/lib/libc/include/libc.h
/trunk/uspace/lib/libc/include/syscall.h
2601 6085 d 8 h jermar /trunk/kernel/generic/src/ipc/ Fix and improve two IPC related comments.  
/trunk/kernel/generic/src/ipc/ipc.c
/trunk/kernel/generic/src/ipc/sysipc.c
2574 6101 d 5 h jermar /trunk/kernel/generic/src/lib/ Fix elf.c's formatting and add code that can be later enhanced and used to
remember task's TLS section alignment, address and size.
 
/trunk/kernel/generic/src/lib/elf.c
2572 6122 d 20 h jermar /trunk/kernel/ Remove duplicit implementation of strlen() in kernel, rename is_digit(),
is_white() and co. to their standard names (e.g. isdigit(), isspace()) and
remove duplicit implementation of isdigit(). Fix cstyle in kernel printf()
implementation.
 
/trunk/kernel/genarch/src/kbd/key.c
/trunk/kernel/generic/include/macros.h
/trunk/kernel/generic/src/console/kconsole.c
/trunk/kernel/generic/src/printf/printf_core.c
2571 6123 d 10 h jermar /trunk/kernel/generic/src/printf/ Fix the string printing precision bug also in the kernel.  
/trunk/kernel/generic/src/printf/printf_core.c
2557 6128 d 13 h jermar /trunk/kernel/generic/src/ipc/ Enable forwarding of IPC_M_AS_AREA_SEND, IPC_M_AS_AREA_RECV, IPC_M_DATA_SEND
calls. In order to prevent the forwarder from cloberring the call data (i.e.
source and destination address, and size) by treating these three methods as
immutable on forward. This feature is experimental, but has huge benefits in
that it can significantly reduce the amount of data sharing (the middle man need
not modify its address space mappings) or the amount of data copying (the middle
man need not receive the data from the sender and then resend them to the next
recipient). As a result, it can reduce N such calls for a communication channel
with N tasks along the way to 1 such call.
 
/trunk/kernel/generic/src/ipc/sysipc.c
2556 6128 d 14 h jermar /trunk/kernel/generic/ Rename as_get_size() to as_area_get_size() and add a doxygen comment.  
/trunk/kernel/generic/include/mm/as.h
/trunk/kernel/generic/src/ipc/sysipc.c
/trunk/kernel/generic/src/mm/as.c
2504 6190 d 6 h jermar /trunk/kernel/generic/ Give the AVL tree walkers the possibility to take an argument.
Each walker is now supposed to return a bool value to support walk termination.

Switch over from the tasks_btree B+tree to tasks_tree AVL tree.
This makes the fix for ticket #48 complete.
 
/trunk/kernel/generic/include/adt/avl.h
/trunk/kernel/generic/include/proc/task.h
/trunk/kernel/generic/src/adt/avl.c
/trunk/kernel/generic/src/proc/task.c
/trunk/kernel/generic/src/proc/thread.c
2503 6190 d 7 h jermar /trunk/kernel/generic/src/adt/ Get rid of code duplicities in the insert path into an AVL tree.  
/trunk/kernel/generic/src/adt/avl.c
2502 6190 d 11 h jermar /trunk/kernel/generic/ Replace the threads_btree B+tree with an AVL tree. The new variable is called
threads_tree. For printing list of threads, use the new AVL tree walker
mechanism.

This solves half of ticket #48.
 
/trunk/kernel/generic/include/proc/thread.h
/trunk/kernel/generic/src/proc/thread.c
2501 6190 d 11 h jermar /trunk/kernel/generic/ Add explicit type for an AVL tree key.
Add function to walk an AVL tree using a supplied walker.
 
/trunk/kernel/generic/include/adt/avl.h
/trunk/kernel/generic/src/adt/avl.c
2499 6190 d 13 h jermar /trunk/kernel/ Import the AVL tree implementation from the RCU branch.  
/trunk/kernel/generic/include/adt/avl.h
/trunk/kernel/generic/src/adt/avl.c
/trunk/kernel/test/avltree
2494 6208 d 4 h jermar /trunk/kernel/generic/ Implement a new mechanism for copying data between two address spaces based on
IPC. New system method IPC_M_DATA_SEND is introduced. The implementation is
generic and does not make use of any possible architecture optimizations such as
direct copy from one address space to another.
 
/trunk/kernel/generic/include/ipc/ipc.h
/trunk/kernel/generic/src/ipc/ipc.c
/trunk/kernel/generic/src/ipc/sysipc.c
2487 6217 d 6 h jermar /trunk/kernel/generic/src/proc/ Kernel stack address was printed twice.  
/trunk/kernel/generic/src/proc/thread.c
2472 6232 d 5 h jermar /trunk/kernel/generic/src/ipc/ Some left-over stuff from the last commit (IPC cleanup and improved
comments.)
 
/trunk/kernel/generic/src/ipc/ipc.c
2471 6232 d 5 h jermar /trunk/ Greatly improve comments in the IPC layer.
Now I think I finally start to understand our IPC internals :-)
 
/trunk/kernel/generic/include/ipc/ipc.h
/trunk/kernel/generic/include/ipc/ipcrsc.h
/trunk/kernel/generic/include/ipc/irq.h
/trunk/kernel/generic/src/ipc/ipc.c
/trunk/kernel/generic/src/ipc/ipcrsc.c
/trunk/kernel/generic/src/ipc/irq.c
/trunk/kernel/generic/src/ipc/sysipc.c
/trunk/uspace/libc/generic/ipc.c
/trunk/uspace/libc/include/ipc/ipc.h
/trunk/uspace/ns/ns.c
/trunk/uspace/pci/pci.c
/trunk/uspace/rd/rd.c
2470 6236 d 3 h jermar /trunk/ Fix a double-free recently introduced in revision r2436.
Add a comment clarifying the life-cycle of the kernel_uarg structure.

Comment out the freeing of userspace thread stack while still running on it.
This should be fixed by implementing userspace version of thread_join().
 
/trunk/kernel/generic/src/proc/thread.c
/trunk/uspace/libc/generic/thread.c
2467 6236 d 7 h jermar /trunk/ Improve comments for arch-specific implementations of hierarchical
4-level page tables. Improve formatting.
 
/trunk/boot/genarch/include/softint
/trunk/boot/generic/genarch
/trunk/kernel/arch/amd64/include/mm/page.h
/trunk/kernel/arch/arm32/include/mm/page.h
/trunk/kernel/arch/arm32/include/mm/page_fault.h
/trunk/kernel/arch/ia32/include/mm/page.h
/trunk/kernel/arch/ia32xen/include/mm/page.h
/trunk/kernel/arch/mips32/include/mm/page.h
/trunk/kernel/arch/ppc32/include/mm/page.h
/trunk/kernel/arch/ppc64/include/mm/page.h
/trunk/kernel/genarch/include/mm/page_ht.h
/trunk/kernel/genarch/include/mm/page_pt.h
/trunk/kernel/generic/src/mm/backend_elf.c
/trunk/kernel/generic/src/syscall/syscall.c
2465 6241 d 10 h jermar /trunk/ Merge arm32 into trunk.  
/trunk/boot/arch/arm32/loader
/trunk/boot/doc
/trunk/boot/genarch/division.c
/trunk/boot/genarch/include
/trunk/boot/generic/genarch
/trunk/kernel/arch/arm32/include/asm
/trunk/kernel/arch/arm32/include/boot.h
/trunk/kernel/arch/arm32/include/console.h
/trunk/kernel/arch/arm32/include/debug
/trunk/kernel/arch/arm32/include/drivers
/trunk/kernel/arch/arm32/include/machine.h
/trunk/kernel/arch/arm32/include/mainpage.h
/trunk/kernel/arch/arm32/include/mm/page_fault.h
/trunk/kernel/arch/arm32/include/regutils.h
/trunk/kernel/arch/arm32/include/stack.h
/trunk/kernel/arch/arm32/src/asm.S
/trunk/kernel/arch/arm32/src/console.c
/trunk/kernel/arch/arm32/src/debug
/trunk/kernel/arch/arm32/src/drivers
/trunk/kernel/arch/arm32/src/exception.c
/trunk/kernel/arch/arm32/src/interrupt.c
/trunk/kernel/arch/arm32/src/mm/memory_init.c
/trunk/kernel/arch/arm32/src/mm/page_fault.c
/trunk/kernel/arch/arm32/src/mm/tlb.c
/trunk/kernel/arch/arm32/src/panic.S
/trunk/kernel/arch/arm32/src/userspace.c
/trunk/kernel/doc/arch/arm32
/trunk/tools/cygwin_symlink_patch.sh
/trunk/uspace/kbd/arch/arm32/src/kbd_gxemul.c
/trunk/uspace/libc/arch/arm32/src/eabi.S
/trunk/uspace/libc/arch/arm32/src/dummy.S
/trunk/HelenOS.config
/trunk/boot/arch/arm32/Makefile.inc
/trunk/boot/arch/arm32/loader/Makefile
/trunk/boot/boot.config
/trunk/boot/generic/align.h
/trunk/boot/generic/gentypes.h
/trunk/boot/generic/printf.c
/trunk/boot/generic/printf.h
/trunk/boot/generic/stdarg.h
/trunk/kernel/arch/amd64/include/mm/page.h
/trunk/kernel/arch/arm32/Makefile.inc
/trunk/kernel/arch/arm32/_link.ld.in
/trunk/kernel/arch/arm32/include/arch.h
/trunk/kernel/arch/arm32/include/arg.h
/trunk/kernel/arch/arm32/include/asm.h
/trunk/kernel/arch/arm32/include/atomic.h
/trunk/kernel/arch/arm32/include/barrier.h
/trunk/kernel/arch/arm32/include/byteorder.h
/trunk/kernel/arch/arm32/include/context.h
/trunk/kernel/arch/arm32/include/cpu.h
/trunk/kernel/arch/arm32/include/cycle.h
/trunk/kernel/arch/arm32/include/elf.h
/trunk/kernel/arch/arm32/include/exception.h
/trunk/kernel/arch/arm32/include/faddr.h
/trunk/kernel/arch/arm32/include/fpu_context.h
/trunk/kernel/arch/arm32/include/interrupt.h
/trunk/kernel/arch/arm32/include/memstr.h
/trunk/kernel/arch/arm32/include/mm/as.h
/trunk/kernel/arch/arm32/include/mm/asid.h
/trunk/kernel/arch/arm32/include/mm/frame.h
/trunk/kernel/arch/arm32/include/mm/memory_init.h
/trunk/kernel/arch/arm32/include/mm/page.h
/trunk/kernel/arch/arm32/include/mm/tlb.h
/trunk/kernel/arch/arm32/include/proc/task.h
/trunk/kernel/arch/arm32/include/proc/thread.h
/trunk/kernel/arch/arm32/include/types.h
/trunk/kernel/arch/arm32/src/arm32.c
/trunk/kernel/arch/arm32/src/context.S
/trunk/kernel/arch/arm32/src/cpu/cpu.c
/trunk/kernel/arch/arm32/src/ddi/ddi.c
/trunk/kernel/arch/arm32/src/dummy.S
/trunk/kernel/arch/arm32/src/mm/as.c
/trunk/kernel/arch/arm32/src/mm/frame.c
/trunk/kernel/arch/arm32/src/mm/page.c
/trunk/kernel/arch/arm32/src/start.S
/trunk/kernel/arch/ia32/include/mm/page.h
/trunk/kernel/arch/ia32xen/include/mm/page.h
/trunk/kernel/arch/mips32/include/mm/page.h
/trunk/kernel/arch/ppc32/include/mm/page.h
/trunk/kernel/arch/ppc64/include/mm/page.h
/trunk/kernel/doc/AUTHORS
/trunk/kernel/doc/doxygroups.h
/trunk/kernel/genarch/include/mm/page_pt.h
/trunk/kernel/genarch/src/mm/as_pt.c
/trunk/kernel/genarch/src/mm/page_pt.c
/trunk/kernel/generic/include/mm/frame.h
/trunk/kernel/generic/src/printf/printf.c
/trunk/kernel/kernel.config
/trunk/uspace/kbd/Makefile
/trunk/uspace/kbd/arch/arm32/include/kbd.h
/trunk/uspace/kbd/arch/arm32/src/kbd.c
/trunk/uspace/libc/arch/arm32/Makefile.inc
/trunk/uspace/libc/arch/arm32/_link.ld.in
/trunk/uspace/libc/arch/arm32/include/atomic.h
/trunk/uspace/libc/arch/arm32/include/config.h
/trunk/uspace/libc/arch/arm32/include/endian.h
/trunk/uspace/libc/arch/arm32/include/faddr.h
/trunk/uspace/libc/arch/arm32/include/limits.h
/trunk/uspace/libc/arch/arm32/include/psthread.h
/trunk/uspace/libc/arch/arm32/include/stackarg.h
/trunk/uspace/libc/arch/arm32/include/syscall.h
/trunk/uspace/libc/arch/arm32/include/thread.h
/trunk/uspace/libc/arch/arm32/include/types.h
/trunk/uspace/libc/arch/arm32/src/entry.s
/trunk/uspace/libc/arch/arm32/src/psthread.S
/trunk/uspace/libc/arch/arm32/src/syscall.c
/trunk/uspace/libc/arch/arm32/src/thread.c
/trunk/uspace/libc/arch/arm32/src/thread_entry.s
/trunk/uspace/softfloat/arch/arm32/include/functions.h
2462 6243 d 4 h jermar /trunk/kernel/ Replace gcc-specific __FUNCTION__ with C99 __func__.
suncc's xregs=no%float can be used only on sparc64.
 
/trunk/kernel/Makefile
/trunk/kernel/arch/amd64/src/interrupt.c
/trunk/kernel/arch/ia32/src/smp/mps.c
/trunk/kernel/arch/ia32xen/src/smp/mps.c
/trunk/kernel/arch/ia64/src/mm/tlb.c
/trunk/kernel/arch/sparc64/Makefile.inc
/trunk/kernel/arch/sparc64/src/mm/tlb.c
/trunk/kernel/arch/sparc64/src/smp/smp.c
/trunk/kernel/arch/sparc64/src/trap/exception.c
/trunk/kernel/generic/include/panic.h
/trunk/kernel/generic/include/synch/spinlock.h
/trunk/kernel/generic/src/console/kconsole.c
2451 6245 d 5 h jermar /trunk/kernel/generic/ JoinMe -> Lingering  
/trunk/kernel/generic/include/proc/thread.h
/trunk/kernel/generic/src/proc/scheduler.c
/trunk/kernel/generic/src/proc/thread.c
2447 6248 d 9 h jermar /trunk/kernel/generic/src/main/ Split accidently joined lines.  
/trunk/kernel/generic/src/main/uinit.c
2446 6248 d 9 h jermar /trunk/kernel/generic/ More efficient and simpler task termination.

Based on the assumption, that after its creation, only the task itself can create more threads for itself,
the last thread with userspace context to execute thread_exit() will perform futex and IPC cleanup. When
the task has no threads, it is destroyed. Both the cleanup and destruction is controlled by reference
counting.

As for userspace threads, even though there could be a global garbage collector for joining threads, it is
much simpler if the uinit thread detaches itself before switching to userspace.

task_kill() is now an idempotent operation. It just instructs the threads within a task to exit.

Change in the name of a thread state: Undead -> JoinMe.
 
/trunk/kernel/generic/include/adt/list.h
/trunk/kernel/generic/include/proc/task.h
/trunk/kernel/generic/include/proc/thread.h
/trunk/kernel/generic/src/main/uinit.c
/trunk/kernel/generic/src/proc/scheduler.c
/trunk/kernel/generic/src/proc/task.c
/trunk/kernel/generic/src/proc/thread.c
2445 6248 d 11 h decky /trunk/ initial merge of branches/fs
(not finished, huge cleanup is needed)
 
/trunk/uspace/libc/generic/io/file.c
/trunk/uspace/libc/include/io/file.h
/trunk/uspace/rd/rd.h
/trunk/kernel/doc/AUTHORS
/trunk/kernel/generic/include/errno.h
/trunk/kernel/generic/include/lib/rd.h
/trunk/kernel/generic/src/lib/rd.c
/trunk/kernel/generic/src/main/kinit.c
/trunk/uspace/libc/include/ipc/services.h
/trunk/uspace/rd/rd.c
2441 6249 d 3 h decky /trunk/kernel/ fix ICC compilation  
/trunk/kernel/arch/amd64/include/debugger.h
/trunk/kernel/arch/amd64/src/debugger.c
/trunk/kernel/arch/ia32/include/asm.h
/trunk/kernel/arch/ia32/include/context.h
/trunk/kernel/arch/ia32/include/mm/frame.h
/trunk/kernel/arch/ia32/include/smp/apic.h
/trunk/kernel/arch/ia32/src/ddi/ddi.c
/trunk/kernel/arch/ia32/src/mm/page.c
/trunk/kernel/arch/ia32/src/proc/scheduler.c
/trunk/kernel/arch/ia32/src/smp/apic.c
/trunk/kernel/arch/ia32/src/smp/mps.c
/trunk/kernel/arch/ia32/src/smp/smp.c
/trunk/kernel/genarch/src/acpi/acpi.c
/trunk/kernel/generic/include/interrupt.h
/trunk/kernel/generic/src/printf/printf_core.c
2440 6249 d 3 h jermar /trunk/kernel/generic/ Fix the problem with sys_thread_create() by splitting the create and attach functionality of
thread_create(). Now it is possible to specify a flag that will cause thread_create() to only allocate and
initialize the thread structure. A call to thread_attach() will make the thread visible to the system.
This arrangement makes it easier to undo creation of a thread in case of a failure in sys_thread_create().
 
/trunk/kernel/generic/include/proc/thread.h
/trunk/kernel/generic/src/proc/thread.c
2436 6250 d 5 h jermar /trunk/ Fix two memory leaks.

In kernel, kernel_uarg structure needs to be deallocated when a thread
with userspace context is destroyed.

In userspace, the return value of the SYS_THREAD_CREATE must be checked
for error conditions and in case of error, uarg and stack must be freed
up.
 
/trunk/kernel/generic/src/proc/task.c
/trunk/kernel/generic/src/proc/thread.c
/trunk/uspace/libc/generic/thread.c
2359 6262 d 14 h jermar /trunk/ Improve comments for the IPC subsystem.
Fix formatting and indentation.
 
/trunk/kernel/generic/src/ipc/ipcrsc.c
/trunk/kernel/generic/src/ipc/sysipc.c
/trunk/uspace/libc/generic/ipc.c
2319 6270 d 14 h decky /trunk/kernel/generic/src/console/ run mcall only on active CPUs  
/trunk/kernel/generic/src/console/cmd.c
2310 6273 d 6 h jermar /trunk/kernel/generic/ Cleanup the waitq_wakeup() interface.
Replace numeric constants (i.e. 0)
and boolean constants (i.e. false) with
more readable WAKEUP_FIRST. Also change the
type of the second argument of waitq_wakeup()
to a newly introduced type wakeup_mode_t.

Fix behaviour of waitq_wakeup() in case
that WAKEUP_ALL semantics is required
but no threads are sleeping in the wait
queue. This is a similar fix to that of
Jan Hudecek committed in the RCU branch,
but, IMHO, is more straightforward and
also doesn't eat up previous missed
wakeups.
 
/trunk/kernel/generic/include/synch/waitq.h
/trunk/kernel/generic/src/ipc/ipc.c
/trunk/kernel/generic/src/proc/scheduler.c
/trunk/kernel/generic/src/synch/waitq.c
2285 6285 d 14 h jermar /trunk/kernel/generic/src/proc/ Formatting and indentation fixes.  
/trunk/kernel/generic/src/proc/scheduler.c
2275 6290 d 6 h decky /trunk/kernel/generic/ add fancy uptime kconsole command  
/trunk/kernel/generic/include/time/clock.h
/trunk/kernel/generic/src/console/cmd.c
/trunk/kernel/generic/src/time/clock.c
2272 6291 d 6 h jermar /trunk/kernel/ Indentation and formatting fixes.  
/trunk/kernel/arch/sparc64/include/barrier.h
/trunk/kernel/arch/sparc64/src/cpu/cpu.c
/trunk/kernel/arch/sparc64/src/mm/as.c
/trunk/kernel/arch/sparc64/src/proc/scheduler.c
/trunk/kernel/arch/sparc64/src/proc/thread.c
/trunk/kernel/arch/sparc64/src/smp/ipi.c
/trunk/kernel/arch/sparc64/src/smp/smp.c
/trunk/kernel/generic/src/lib/memstr.c
2268 6292 d 6 h jermar /trunk/kernel/generic/ Document and assert proper usage of THREAD_FLAG_WIRED.
Original patch by Jan Hudecek.
 
/trunk/kernel/generic/include/proc/thread.h
/trunk/kernel/generic/src/proc/thread.c
2229 6301 d 11 h jermar /trunk/ Revert some of the changes introduced in revision 2209.
I think it is not correct to remove serialization of pseudo threads in printf_core.c.
With thread-level futex serialization, several pseudo threads running in one thread could easily deadlock
the task.

Add a dedicated futex serialization to thread1.c test only.
 
/trunk/kernel/generic/src/proc/thread.c
/trunk/uspace/libc/arch/sparc64/src/thread_entry.s
/trunk/uspace/libc/generic/io/printf_core.c
/trunk/uspace/libc/generic/io/vprintf.c
/trunk/uspace/tester/fault/fault1.c
/trunk/uspace/tester/fault/fault2.c
/trunk/uspace/tester/thread/thread1.c
2227 6301 d 19 h decky /trunk/kernel/ start shutdown infrastructure  
/trunk/kernel/generic/src/main/shutdown.c
/trunk/kernel/Makefile
/trunk/kernel/arch/amd64/src/pm.c
/trunk/kernel/arch/arm32/src/arm32.c
/trunk/kernel/arch/ia32/src/pm.c
/trunk/kernel/arch/ia32xen/src/ia32xen.c
/trunk/kernel/arch/ia64/src/ia64.c
/trunk/kernel/arch/mips32/src/mips32.c
/trunk/kernel/arch/ppc32/src/drivers/cuda.c
/trunk/kernel/arch/ppc64/src/ppc64.c
/trunk/kernel/arch/sparc64/src/sparc64.c
/trunk/kernel/generic/include/arch.h
/trunk/kernel/generic/include/proc/task.h
/trunk/kernel/generic/src/console/cmd.c
/trunk/kernel/generic/src/proc/task.c
/trunk/kernel/kernel.config
2224 6302 d 1 h decky /trunk/kernel/generic/src/console/ detach joined thread  
/trunk/kernel/generic/src/console/cmd.c