Subversion Repositories HelenOS

Rev

Go to most recent revision | Show changed files | Details | Compare with Previous | Blame | RSS feed

Filtering Options

Rev Age Author Path Log message Diff
2907 5934 d 3 h jermar /trunk/kernel/generic/src/proc/ Improve comment for thread_create().  
2802 5971 d 8 h jermar /trunk/kernel/generic/ Fix initialization of answerbox->task in ipc_answerbox_init.
Contributed by Jiri Svoboda.
 
2790 5977 d 9 h jermar /trunk/kernel/generic/src/proc/ Fix typo ALV tree vs. AVL tree.  
2765 5997 d 23 h jermar /trunk/kernel/generic/src/proc/ tasklet.c needs to include config.h  
2746 6009 d 2 h decky /trunk/kernel/ start merging tasklets (more or less a rewrite)  
2745 6009 d 7 h decky /trunk/ code cleanup (mostly signed/unsigned)
allow extra compiler warnings
 
2712 6035 d 4 h decky /trunk/kernel/ prettyprint output  
2632 6096 d 18 h decky /trunk/kernel/generic/src/proc/ try to kill the tasks fewer times by introducing a delay in iterations  
2504 6221 d 23 h jermar /trunk/kernel/generic/ Give the AVL tree walkers the possibility to take an argument.
Each walker is now supposed to return a bool value to support walk termination.

Switch over from the tasks_btree B+tree to tasks_tree AVL tree.
This makes the fix for ticket #48 complete.
 
2502 6222 d 5 h jermar /trunk/kernel/generic/ Replace the threads_btree B+tree with an AVL tree. The new variable is called
threads_tree. For printing list of threads, use the new AVL tree walker
mechanism.

This solves half of ticket #48.
 
2487 6249 d 0 h jermar /trunk/kernel/generic/src/proc/ Kernel stack address was printed twice.  
2470 6267 d 21 h jermar /trunk/ Fix a double-free recently introduced in revision r2436.
Add a comment clarifying the life-cycle of the kernel_uarg structure.

Comment out the freeing of userspace thread stack while still running on it.
This should be fixed by implementing userspace version of thread_join().
 
2451 6276 d 23 h jermar /trunk/kernel/generic/ JoinMe -> Lingering  
2446 6280 d 3 h jermar /trunk/kernel/generic/ More efficient and simpler task termination.

Based on the assumption, that after its creation, only the task itself can create more threads for itself,
the last thread with userspace context to execute thread_exit() will perform futex and IPC cleanup. When
the task has no threads, it is destroyed. Both the cleanup and destruction is controlled by reference
counting.

As for userspace threads, even though there could be a global garbage collector for joining threads, it is
much simpler if the uinit thread detaches itself before switching to userspace.

task_kill() is now an idempotent operation. It just instructs the threads within a task to exit.

Change in the name of a thread state: Undead -> JoinMe.
 
2440 6280 d 21 h jermar /trunk/kernel/generic/ Fix the problem with sys_thread_create() by splitting the create and attach functionality of
thread_create(). Now it is possible to specify a flag that will cause thread_create() to only allocate and
initialize the thread structure. A call to thread_attach() will make the thread visible to the system.
This arrangement makes it easier to undo creation of a thread in case of a failure in sys_thread_create().
 
2436 6281 d 23 h jermar /trunk/ Fix two memory leaks.

In kernel, kernel_uarg structure needs to be deallocated when a thread
with userspace context is destroyed.

In userspace, the return value of the SYS_THREAD_CREATE must be checked
for error conditions and in case of error, uarg and stack must be freed
up.
 
2310 6305 d 0 h jermar /trunk/kernel/generic/ Cleanup the waitq_wakeup() interface.
Replace numeric constants (i.e. 0)
and boolean constants (i.e. false) with
more readable WAKEUP_FIRST. Also change the
type of the second argument of waitq_wakeup()
to a newly introduced type wakeup_mode_t.

Fix behaviour of waitq_wakeup() in case
that WAKEUP_ALL semantics is required
but no threads are sleeping in the wait
queue. This is a similar fix to that of
Jan Hudecek committed in the RCU branch,
but, IMHO, is more straightforward and
also doesn't eat up previous missed
wakeups.
 
2285 6317 d 8 h jermar /trunk/kernel/generic/src/proc/ Formatting and indentation fixes.  
2268 6323 d 23 h jermar /trunk/kernel/generic/ Document and assert proper usage of THREAD_FLAG_WIRED.
Original patch by Jan Hudecek.
 
2229 6333 d 5 h jermar /trunk/ Revert some of the changes introduced in revision 2209.
I think it is not correct to remove serialization of pseudo threads in printf_core.c.
With thread-level futex serialization, several pseudo threads running in one thread could easily deadlock
the task.

Add a dedicated futex serialization to thread1.c test only.
 
2227 6333 d 12 h decky /trunk/kernel/ start shutdown infrastructure  
2216 6334 d 23 h decky /trunk/ make thread ID 64 bit (task ID is 64 bit already)
cleanup thread syscalls
 
2187 6336 d 6 h decky /trunk/kernel/generic/ add syscall for getting current thread ID  
2183 6337 d 2 h jermar /trunk/kernel/generic/ Continue to de-oversynchronize the kernel.
- replace as->refcount with an atomic counter; accesses to this
reference counter are not to be done when the as->lock mutex is held;
this gets us rid of mutex_lock_active();

Remove the possibility of a deadlock between TLB shootdown and asidlock.
- get rid of mutex_lock_active() on as->lock
- when locking the asidlock spinlock, always do it conditionally and with
preemption disabled; in the unsuccessful case, enable interrupts and try again
- there should be no deadlock between TLB shootdown and the as->lock mutexes
- PLEASE REVIEW !!!

Add DEADLOCK_PROBE's to places where we have spinlock_trylock() loops.
 
2118 6396 d 4 h decky /trunk/kernel/generic/src/ explicit typecast, fix signed/unsigned comparison  
2109 6397 d 7 h jermar /trunk/kernel/generic/ Revert thread_interrupt_sleep() to waitq_interrupt_sleep().
I'd prefer that this, IMO, waitq related stuff stays together.
 
2089 6404 d 5 h decky /trunk/ huge type system cleanup
remove cyclical type dependencies across multiple header files
many minor coding style fixes
 
2087 6405 d 1 h jermar /trunk/kernel/ Indentaion and formatting changes even Martin will like :-)  
2071 6414 d 22 h jermar /trunk/ (c) versus (C)  
2068 6422 d 5 h jermar /trunk/kernel/ Formatting and indentation fixes.  
2067 6425 d 4 h jermar /trunk/kernel/ More formatting changes.  
2050 6444 d 8 h decky /trunk/kernel/ benchmarking with statistics (initial)  
2048 6447 d 0 h jermar /trunk/ Formatting and indentation changes.  
2042 6449 d 2 h decky /trunk/kernel/ introduce uncounted threads, whose accounting doesn't affect accumulated task accounting
run tests in kconsole thread again
 
2041 6449 d 3 h decky /trunk/kernel/generic/src/proc/ revert 2040  
2040 6449 d 5 h decky /trunk/kernel/generic/src/proc/ add forgotten btree_remove()  
2039 6449 d 6 h decky /trunk/kernel/generic/ accumulate task accounting, run tests as separate kernel task  
2035 6450 d 4 h decky /trunk/kernel/generic/src/ more fancy kconsole output  
2032 6450 d 5 h decky /trunk/kernel/generic/src/proc/ proper initialization of last_cycle  
2030 6450 d 6 h decky /trunk/kernel/ thread CPU cycles accounting