WebSVN – HelenOS – Diff – /branches/tracing/uspace/srv/fs/tmpfs/tmpfs_ops.c

 #define DENTRIES_BUCKETS    256
 #define TMPFS_GET_INDEX(x)  (((tmpfs_dentry_t *)(x))->index)
 #define TMPFS_GET_LNKCNT(x) 1
+/* Forward declarations of static functions. */
+static void *create_node(int);
+static bool link_node(void *, void *, const char *);
+static int unlink_node(void *);
+static void destroy_node(void *);
-/*
- * Hash table of all directory entries.
+/** Hash table of all directory entries. */
- */
 hash_table_t dentries;
 static hash_index_t dentries_hash(unsigned long *key)
+{
     return *key % DENTRIES_BUCKETS;
 static bool tmpfs_init(void)
+{
     if (!hash_table_create(&dentries, DENTRIES_BUCKETS, 1, &dentries_ops))
         return false;
-    root = (tmpfs_dentry_t *) malloc(sizeof(tmpfs_dentry_t));
+    root = (tmpfs_dentry_t *) create_node(L_DIRECTORY);
-    if (!root)
-        return false;
-    tmpfs_dentry_initialize(root);
-    root->index = tmpfs_next_index++;
-    root->name = "";
-    root->type = TMPFS_DIRECTORY;
-    hash_table_insert(&dentries, &root->index, &root->dh_link);
-    return true;
+    return root != NULL;
+}
 /** Compare one component of path to a directory entry.
+ *
  * @param nodep     Node to compare the path component with.
     tmpfs_dentry_t *dentry = (tmpfs_dentry_t *) nodep;
     return !strcmp(dentry->name, component);
+}
-static void *create_node(void *nodep,
+void *create_node(int lflag)
-    const char *component, int lflag)
+{
-    tmpfs_dentry_t *dentry = (tmpfs_dentry_t *) nodep;
-    assert(dentry->type == TMPFS_DIRECTORY);
     assert((lflag & L_FILE) ^ (lflag & L_DIRECTORY));
     tmpfs_dentry_t *node = malloc(sizeof(tmpfs_dentry_t));
     if (!node)
         return NULL;
-    size_t len = strlen(component);
-    char *name = malloc(len + 1);
-    if (!name) {
-        free(node);
-        return NULL;
-    }
-    strcpy(name, component);
     tmpfs_dentry_initialize(node);
     node->index = tmpfs_next_index++;
-    node->name = name;
-    node->parent = dentry;
     if (lflag & L_DIRECTORY)
         node->type = TMPFS_DIRECTORY;
     else
         node->type = TMPFS_FILE;
+    /* Insert the new node into the dentry hash table. */
+    hash_table_insert(&dentries, &node->index, &node->dh_link);
+    return (void *) node;
+}
+bool link_node(void *prnt, void *chld, const char *nm)
+{
+    tmpfs_dentry_t *parentp = (tmpfs_dentry_t *) prnt;
+    tmpfs_dentry_t *childp = (tmpfs_dentry_t *) chld;
+    assert(parentp->type == TMPFS_DIRECTORY);
+    size_t len = strlen(nm);
+    char *name = malloc(len + 1);
+    if (!name)
+        return false;
+    strcpy(name, nm);
+    childp->name = name;
     /* Insert the new node into the namespace. */
-    if (dentry->child) {
+    if (parentp->child) {
-        tmpfs_dentry_t *tmp = dentry->child;
+        tmpfs_dentry_t *tmp = parentp->child;
         while (tmp->sibling)
             tmp = tmp->sibling;
-        tmp->sibling = node;
+        tmp->sibling = childp;
     } else {
-        dentry->child = node;
+        parentp->child = childp;
+    }
+    childp->parent = parentp;
-    /* Insert the new node into the dentry hash table. */
-    hash_table_insert(&dentries, &node->index, &node->dh_link);
-    return (void *) node;
+    return true;
+}
-static int destroy_component(void *nodeptr)
+int unlink_node(void *nodeptr)
+{
     tmpfs_dentry_t *dentry = (tmpfs_dentry_t *)nodeptr;
     if (dentry->child)
         return ENOTEMPTY;
         tmp->sibling = dentry->sibling;
+    }
     dentry->sibling = NULL;
     dentry->parent = NULL;
+    free(dentry->name);
+    dentry->name = NULL;
     return EOK;
+}
+void destroy_node(void *nodep)
+{
+    tmpfs_dentry_t *dentry = (tmpfs_dentry_t *) nodep;
+    assert(!dentry->child);
+    assert(!dentry->sibling);
+    unsigned long index = dentry->index;
+    hash_table_remove(&dentries, &index, 1);
+    if (dentry->type == TMPFS_FILE)
+        free(dentry->data);
+    free(dentry);
+}
 void tmpfs_lookup(ipc_callid_t rid, ipc_call_t *request)
+{
     unsigned next = IPC_GET_ARG1(*request);
     unsigned last = IPC_GET_ARG2(*request);
     int dev_handle = IPC_GET_ARG3(*request);
                 /* no components left and L_CREATE specified */
                 if (dcur->type != TMPFS_DIRECTORY) {
                     ipc_answer_0(rid, ENOTDIR);
                     return;
+                }
-                void *nodep = create_node(dcur,
+                void *nodep = create_node(lflag);
-                    component, lflag);
                 if (nodep) {
+                    if (!link_node(dcur, nodep,
+                        component)) {
+                        destroy_node(nodep);
+                        ipc_answer_0(rid, ENOSPC);
+                    } else {
-                    ipc_answer_5(rid, EOK,
+                        ipc_answer_5(rid, EOK,
-                        tmpfs_reg.fs_handle, dev_handle,
+                            tmpfs_reg.fs_handle,
+                            dev_handle,
-                        TMPFS_GET_INDEX(nodep), 0,
+                            TMPFS_GET_INDEX(nodep), 0,
-                        TMPFS_GET_LNKCNT(nodep));
+                            TMPFS_GET_LNKCNT(nodep));
+                    }
                 } else {
                     ipc_answer_0(rid, ENOSPC);
+                }
                 return;
+            }
+            }
             assert(len);
             component[len] = '\0';
             len = 0;
-            void *nodep = create_node(dcur, component, lflag);
+            void *nodep = create_node(lflag);
             if (nodep) {
+                if (!link_node(dcur, nodep, component)) {
+                    destroy_node(nodep);
+                    ipc_answer_0(rid, ENOSPC);
+                } else {
+                    ipc_answer_5(rid, EOK,
-                ipc_answer_5(rid, EOK, tmpfs_reg.fs_handle,
+                        tmpfs_reg.fs_handle,
-                    dev_handle, TMPFS_GET_INDEX(nodep), 0,
+                        dev_handle, TMPFS_GET_INDEX(nodep),
-                    TMPFS_GET_LNKCNT(nodep));
+, TMPFS_GET_LNKCNT(nodep));
+                }
             } else {
                 ipc_answer_0(rid, ENOSPC);
+            }
             return;
+        }
+    }
     /* handle hit */
     if (lflag & L_DESTROY) {
         unsigned old_lnkcnt = TMPFS_GET_LNKCNT(dcur);
-        int res = destroy_component(dcur);
+        int res = unlink_node(dcur);
         ipc_answer_5(rid, (ipcarg_t)res, tmpfs_reg.fs_handle,
             dev_handle, dcur->index, dcur->size, old_lnkcnt);
         return;
+    }
     if ((lflag & (L_CREATE | L_EXCLUSIVE)) == (L_CREATE | L_EXCLUSIVE)) {
     dentry->size = size;
     dentry->data = newdata;
     ipc_answer_0(rid, EOK);
+}
-void tmpfs_free(ipc_callid_t rid, ipc_call_t *request)
+void tmpfs_destroy(ipc_callid_t rid, ipc_call_t *request)
+{
     int dev_handle = IPC_GET_ARG1(*request);
     unsigned long index = IPC_GET_ARG2(*request);
     link_t *hlp;
         ipc_answer_0(rid, ENOENT);
         return;
+    }
     tmpfs_dentry_t *dentry = hash_table_get_instance(hlp, tmpfs_dentry_t,
         dh_link);
-    assert(!dentry->parent);
-    assert(!dentry->child);
-    assert(!dentry->sibling);
-    hash_table_remove(&dentries, &index, 1);
-    if (dentry->type == TMPFS_FILE)
-        free(dentry->data);
-    free(dentry->name);
-    free(dentry);
+    destroy_node(dentry);
     ipc_answer_0(rid, EOK);
+}
 /**
  * @}

Subversion Repositories HelenOS

(root)/branches/tracing/uspace/srv/fs/tmpfs/tmpfs_ops.c @ 4692 – Rev 2739 → 2742