Subversion Repositories HelenOS

Rev

Rev 4583 | Details | Compare with Previous | Last modification | View Log | RSS feed

Rev Author Line No. Line
3521 jermar 1
/*
2
 * Copyright (c) 2008 Jakub Jermar 
3
 * Copyright (c) 2008 Martin Decky 
4
 * All rights reserved.
5
 *
6
 * Redistribution and use in source and binary forms, with or without
7
 * modification, are permitted provided that the following conditions
8
 * are met:
9
 *
10
 * - Redistributions of source code must retain the above copyright
11
 *   notice, this list of conditions and the following disclaimer.
12
 * - Redistributions in binary form must reproduce the above copyright
13
 *   notice, this list of conditions and the following disclaimer in the
14
 *   documentation and/or other materials provided with the distribution.
15
 * - The name of the author may not be used to endorse or promote products
16
 *   derived from this software without specific prior written permission.
17
 *
18
 * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
19
 * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
20
 * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
21
 * IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
22
 * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
23
 * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
24
 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
25
 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
26
 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
27
 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
28
 */
29
 
4001 decky 30
/** @addtogroup libblock
3521 jermar 31
 * @{
4001 decky 32
 */
3521 jermar 33
/**
34
 * @file
35
 * @brief
36
 */
37
 
4001 decky 38
#include "libblock.h"
3521 jermar 39
#include "../../srv/vfs/vfs.h"
3530 jermar 40
#include <ipc/devmap.h>
4400 svoboda 41
#include <ipc/bd.h>
3530 jermar 42
#include <ipc/services.h>
3521 jermar 43
#include <errno.h>
3530 jermar 44
#include <sys/mman.h>
3521 jermar 45
#include <async.h>
46
#include <ipc/ipc.h>
47
#include <as.h>
48
#include <assert.h>
4553 jermar 49
#include <fibril_sync.h>
4509 decky 50
#include <adt/list.h>
51
#include <adt/hash_table.h>
4483 decky 52
#include <mem.h>
3521 jermar 53
 
3531 jermar 54
/** Lock protecting the device connection list */
4553 jermar 55
static FIBRIL_MUTEX_INITIALIZE(dcl_lock);
3531 jermar 56
/** Device connection list head. */
57
static LIST_INITIALIZE(dcl_head);
3530 jermar 58
 
3539 jermar 59
#define CACHE_BUCKETS_LOG2		10
60
#define CACHE_BUCKETS			(1 << CACHE_BUCKETS_LOG2)
61
 
3531 jermar 62
typedef struct {
4553 jermar 63
	fibril_mutex_t lock;
3539 jermar 64
	size_t block_size;		/**< Block size. */
65
	unsigned block_count;		/**< Total number of blocks. */
4611 jermar 66
	unsigned blocks_cached;		/**< Number of cached blocks. */
3539 jermar 67
	hash_table_t block_hash;
68
	link_t free_head;
4572 svoboda 69
	enum cache_mode mode;
3539 jermar 70
} cache_t;
71
 
72
typedef struct {
3531 jermar 73
	link_t link;
4434 jermar 74
	dev_handle_t dev_handle;
3531 jermar 75
	int dev_phone;
4611 jermar 76
	fibril_mutex_t com_area_lock;
3531 jermar 77
	void *com_area;
78
	size_t com_size;
79
	void *bb_buf;
80
	off_t bb_off;
81
	size_t bb_size;
3539 jermar 82
	cache_t *cache;
3531 jermar 83
} devcon_t;
84
 
4583 svoboda 85
static int read_block(devcon_t *devcon, bn_t boff, size_t block_size);
86
static int write_block(devcon_t *devcon, bn_t boff, size_t block_size);
4572 svoboda 87
 
3531 jermar 88
static devcon_t *devcon_search(dev_handle_t dev_handle)
89
{
90
	link_t *cur;
91
 
4553 jermar 92
	fibril_mutex_lock(&dcl_lock);
3531 jermar 93
	for (cur = dcl_head.next; cur != &dcl_head; cur = cur->next) {
94
		devcon_t *devcon = list_get_instance(cur, devcon_t, link);
95
		if (devcon->dev_handle == dev_handle) {
4553 jermar 96
			fibril_mutex_unlock(&dcl_lock);
3531 jermar 97
			return devcon;
98
		}
99
	}
4553 jermar 100
	fibril_mutex_unlock(&dcl_lock);
3531 jermar 101
	return NULL;
102
}
103
 
104
static int devcon_add(dev_handle_t dev_handle, int dev_phone, void *com_area,
3537 jermar 105
   size_t com_size)
3531 jermar 106
{
107
	link_t *cur;
108
	devcon_t *devcon;
109
 
110
	devcon = malloc(sizeof(devcon_t));
111
	if (!devcon)
112
		return ENOMEM;
113
 
114
	link_initialize(&devcon->link);
115
	devcon->dev_handle = dev_handle;
116
	devcon->dev_phone = dev_phone;
4611 jermar 117
	fibril_mutex_initialize(&devcon->com_area_lock);
3531 jermar 118
	devcon->com_area = com_area;
119
	devcon->com_size = com_size;
3537 jermar 120
	devcon->bb_buf = NULL;
121
	devcon->bb_off = 0;
122
	devcon->bb_size = 0;
3539 jermar 123
	devcon->cache = NULL;
3531 jermar 124
 
4553 jermar 125
	fibril_mutex_lock(&dcl_lock);
3531 jermar 126
	for (cur = dcl_head.next; cur != &dcl_head; cur = cur->next) {
127
		devcon_t *d = list_get_instance(cur, devcon_t, link);
128
		if (d->dev_handle == dev_handle) {
4553 jermar 129
			fibril_mutex_unlock(&dcl_lock);
3531 jermar 130
			free(devcon);
131
			return EEXIST;
132
		}
133
	}
134
	list_append(&devcon->link, &dcl_head);
4553 jermar 135
	fibril_mutex_unlock(&dcl_lock);
3531 jermar 136
	return EOK;
137
}
138
 
139
static void devcon_remove(devcon_t *devcon)
140
{
4553 jermar 141
	fibril_mutex_lock(&dcl_lock);
3531 jermar 142
	list_remove(&devcon->link);
4553 jermar 143
	fibril_mutex_unlock(&dcl_lock);
3531 jermar 144
}
145
 
3537 jermar 146
int block_init(dev_handle_t dev_handle, size_t com_size)
3530 jermar 147
{
148
	int rc;
3531 jermar 149
	int dev_phone;
150
	void *com_area;
151
 
152
	com_area = mmap(NULL, com_size, PROTO_READ | PROTO_WRITE,
3530 jermar 153
	    MAP_ANONYMOUS | MAP_PRIVATE, 0, 0);
3531 jermar 154
	if (!com_area) {
3530 jermar 155
		return ENOMEM;
156
	}
157
 
4401 svoboda 158
	dev_phone = devmap_device_connect(dev_handle, IPC_FLAG_BLOCKING);
3530 jermar 159
	if (dev_phone < 0) {
3531 jermar 160
		munmap(com_area, com_size);
3530 jermar 161
		return dev_phone;
162
	}
163
 
3531 jermar 164
	rc = ipc_share_out_start(dev_phone, com_area,
3530 jermar 165
	    AS_AREA_READ | AS_AREA_WRITE);
166
	if (rc != EOK) {
3531 jermar 167
	    	munmap(com_area, com_size);
3530 jermar 168
		ipc_hangup(dev_phone);
169
		return rc;
170
	}
3531 jermar 171
 
3537 jermar 172
	rc = devcon_add(dev_handle, dev_phone, com_area, com_size);
3531 jermar 173
	if (rc != EOK) {
174
		munmap(com_area, com_size);
175
		ipc_hangup(dev_phone);
176
		return rc;
177
	}
178
 
3530 jermar 179
	return EOK;
180
}
181
 
182
void block_fini(dev_handle_t dev_handle)
183
{
3531 jermar 184
	devcon_t *devcon = devcon_search(dev_handle);
185
	assert(devcon);
186
 
187
	devcon_remove(devcon);
188
 
3537 jermar 189
	if (devcon->bb_buf)
190
		free(devcon->bb_buf);
3539 jermar 191
 
192
	if (devcon->cache) {
193
		hash_table_destroy(&devcon->cache->block_hash);
194
		free(devcon->cache);
195
	}
196
 
3531 jermar 197
	munmap(devcon->com_area, devcon->com_size);
198
	ipc_hangup(devcon->dev_phone);
199
 
200
	free(devcon);	
3530 jermar 201
}
202
 
3537 jermar 203
int block_bb_read(dev_handle_t dev_handle, off_t off, size_t size)
204
{
205
	void *bb_buf;
3538 jermar 206
	int rc;
3537 jermar 207
 
208
	devcon_t *devcon = devcon_search(dev_handle);
209
	if (!devcon)
210
		return ENOENT;
211
	if (devcon->bb_buf)
212
		return EEXIST;
213
	bb_buf = malloc(size);
214
	if (!bb_buf)
215
		return ENOMEM;
216
 
4611 jermar 217
	fibril_mutex_lock(&devcon->com_area_lock);
4583 svoboda 218
	rc = read_block(devcon, 0, size);
3538 jermar 219
	if (rc != EOK) {
4611 jermar 220
		fibril_mutex_unlock(&devcon->com_area_lock);
3537 jermar 221
	    	free(bb_buf);
3538 jermar 222
		return rc;
3537 jermar 223
	}
4583 svoboda 224
	memcpy(bb_buf, devcon->com_area, size);
4611 jermar 225
	fibril_mutex_unlock(&devcon->com_area_lock);
4583 svoboda 226
 
3537 jermar 227
	devcon->bb_buf = bb_buf;
228
	devcon->bb_off = off;
229
	devcon->bb_size = size;
230
 
231
	return EOK;
232
}
233
 
3530 jermar 234
void *block_bb_get(dev_handle_t dev_handle)
235
{
3531 jermar 236
	devcon_t *devcon = devcon_search(dev_handle);
237
	assert(devcon);
238
	return devcon->bb_buf;
3530 jermar 239
}
240
 
3539 jermar 241
static hash_index_t cache_hash(unsigned long *key)
242
{
243
	return *key & (CACHE_BUCKETS - 1);
244
}
245
 
246
static int cache_compare(unsigned long *key, hash_count_t keys, link_t *item)
247
{
248
	block_t *b = hash_table_get_instance(item, block_t, hash_link);
249
	return b->boff == *key;
250
}
251
 
252
static void cache_remove_callback(link_t *item)
253
{
254
}
255
 
256
static hash_table_operations_t cache_ops = {
257
	.hash = cache_hash,
258
	.compare = cache_compare,
259
	.remove_callback = cache_remove_callback
260
};
261
 
4572 svoboda 262
int block_cache_init(dev_handle_t dev_handle, size_t size, unsigned blocks,
263
    enum cache_mode mode)
3539 jermar 264
{
265
	devcon_t *devcon = devcon_search(dev_handle);
266
	cache_t *cache;
267
	if (!devcon)
268
		return ENOENT;
269
	if (devcon->cache)
270
		return EEXIST;
271
	cache = malloc(sizeof(cache_t));
272
	if (!cache)
273
		return ENOMEM;
274
 
4553 jermar 275
	fibril_mutex_initialize(&cache->lock);
3539 jermar 276
	list_initialize(&cache->free_head);
277
	cache->block_size = size;
278
	cache->block_count = blocks;
4611 jermar 279
	cache->blocks_cached = 0;
4572 svoboda 280
	cache->mode = mode;
3539 jermar 281
 
282
	if (!hash_table_create(&cache->block_hash, CACHE_BUCKETS, 1,
283
	    &cache_ops)) {
284
		free(cache);
285
		return ENOMEM;
286
	}
287
 
288
	devcon->cache = cache;
289
	return EOK;
290
}
291
 
4611 jermar 292
#define CACHE_LO_WATERMARK	10	
293
#define CACHE_HI_WATERMARK	20	
3540 jermar 294
static bool cache_can_grow(cache_t *cache)
3521 jermar 295
{
4611 jermar 296
	if (cache->blocks_cached < CACHE_LO_WATERMARK)
297
		return true;
298
	if (!list_empty(&cache->free_head))
299
		return false;
3540 jermar 300
	return true;
301
}
302
 
303
static void block_initialize(block_t *b)
304
{
4553 jermar 305
	fibril_mutex_initialize(&b->lock);
3540 jermar 306
	b->refcnt = 1;
307
	b->dirty = false;
4553 jermar 308
	fibril_rwlock_initialize(&b->contents_lock);
3540 jermar 309
	link_initialize(&b->free_link);
310
	link_initialize(&b->hash_link);
311
}
312
 
313
/** Instantiate a block in memory and get a reference to it.
314
 *
315
 * @param dev_handle		Device handle of the block device.
316
 * @param boff			Block offset.
3595 jermar 317
 * @param flags			If BLOCK_FLAGS_NOREAD is specified, block_get()
318
 * 				will not read the contents of the block from the
319
 *				device.
3540 jermar 320
 *
321
 * @return			Block structure.
322
 */
3595 jermar 323
block_t *block_get(dev_handle_t dev_handle, bn_t boff, int flags)
3540 jermar 324
{
325
	devcon_t *devcon;
326
	cache_t *cache;
3521 jermar 327
	block_t *b;
3540 jermar 328
	link_t *l;
329
	unsigned long key = boff;
4611 jermar 330
	bn_t oboff;
3540 jermar 331
 
332
	devcon = devcon_search(dev_handle);
3521 jermar 333
 
3540 jermar 334
	assert(devcon);
335
	assert(devcon->cache);
3521 jermar 336
 
3540 jermar 337
	cache = devcon->cache;
4553 jermar 338
	fibril_mutex_lock(&cache->lock);
3540 jermar 339
	l = hash_table_find(&cache->block_hash, &key);
340
	if (l) {
341
		/*
342
		 * We found the block in the cache.
343
		 */
344
		b = hash_table_get_instance(l, block_t, hash_link);
4553 jermar 345
		fibril_mutex_lock(&b->lock);
3540 jermar 346
		if (b->refcnt++ == 0)
347
			list_remove(&b->free_link);
4553 jermar 348
		fibril_mutex_unlock(&b->lock);
349
		fibril_mutex_unlock(&cache->lock);
3540 jermar 350
	} else {
351
		/*
352
		 * The block was not found in the cache.
353
		 */
354
		int rc;
3544 jermar 355
		bool sync = false;
3521 jermar 356
 
3540 jermar 357
		if (cache_can_grow(cache)) {
358
			/*
359
			 * We can grow the cache by allocating new blocks.
360
			 * Should the allocation fail, we fail over and try to
361
			 * recycle a block from the cache.
362
			 */
363
			b = malloc(sizeof(block_t));
364
			if (!b)
365
				goto recycle;
366
			b->data = malloc(cache->block_size);
367
			if (!b->data) {
368
				free(b);
369
				goto recycle;
370
			}
4611 jermar 371
			cache->blocks_cached++;
3540 jermar 372
		} else {
373
			/*
374
			 * Try to recycle a block from the free list.
375
			 */
376
			unsigned long temp_key;
377
recycle:
378
			assert(!list_empty(&cache->free_head));
379
			l = cache->free_head.next;
380
			list_remove(l);
4611 jermar 381
			b = list_get_instance(l, block_t, free_link);
3544 jermar 382
			sync = b->dirty;
4611 jermar 383
			oboff = b->boff;
3540 jermar 384
			temp_key = b->boff;
385
			hash_table_remove(&cache->block_hash, &temp_key, 1);
386
		}
387
 
388
		block_initialize(b);
389
		b->dev_handle = dev_handle;
390
		b->size = cache->block_size;
391
		b->boff = boff;
3544 jermar 392
		hash_table_insert(&cache->block_hash, &key, &b->hash_link);
393
 
394
		/*
395
		 * Lock the block before releasing the cache lock. Thus we don't
396
		 * kill concurent operations on the cache while doing I/O on the
397
		 * block.
398
		 */
4553 jermar 399
		fibril_mutex_lock(&b->lock);
400
		fibril_mutex_unlock(&cache->lock);
3544 jermar 401
 
402
		if (sync) {
403
			/*
404
			 * The block is dirty and needs to be written back to
405
			 * the device before we can read in the new contents.
406
			 */
4611 jermar 407
			fibril_mutex_lock(&devcon->com_area_lock);
408
			memcpy(devcon->com_area, b->data, b->size);
409
			rc = write_block(devcon, oboff, cache->block_size);
410
			assert(rc == EOK);
411
			fibril_mutex_unlock(&devcon->com_area_lock);
3544 jermar 412
		}
3595 jermar 413
		if (!(flags & BLOCK_FLAGS_NOREAD)) {
414
			/*
415
			 * The block contains old or no data. We need to read
416
			 * the new contents from the device.
417
			 */
4611 jermar 418
			fibril_mutex_lock(&devcon->com_area_lock);
4583 svoboda 419
			rc = read_block(devcon, b->boff, cache->block_size);
3595 jermar 420
			assert(rc == EOK);
4583 svoboda 421
			memcpy(b->data, devcon->com_area, cache->block_size);
4611 jermar 422
			fibril_mutex_unlock(&devcon->com_area_lock);
3595 jermar 423
		}
3544 jermar 424
 
4553 jermar 425
		fibril_mutex_unlock(&b->lock);
3521 jermar 426
	}
427
	return b;
428
}
429
 
3543 jermar 430
/** Release a reference to a block.
431
 *
3544 jermar 432
 * If the last reference is dropped, the block is put on the free list.
3543 jermar 433
 *
434
 * @param block		Block of which a reference is to be released.
435
 */
3521 jermar 436
void block_put(block_t *block)
437
{
3543 jermar 438
	devcon_t *devcon = devcon_search(block->dev_handle);
439
	cache_t *cache;
4572 svoboda 440
	int rc;
3543 jermar 441
 
442
	assert(devcon);
443
	assert(devcon->cache);
444
 
445
	cache = devcon->cache;
4553 jermar 446
	fibril_mutex_lock(&cache->lock);
447
	fibril_mutex_lock(&block->lock);
3543 jermar 448
	if (!--block->refcnt) {
449
		/*
4611 jermar 450
		 * Last reference to the block was dropped. Either free the
451
		 * block or put it on the free list.
3543 jermar 452
		 */
4611 jermar 453
		if (cache->blocks_cached > CACHE_HI_WATERMARK) {
454
			/*
455
			 * Currently there are too many cached blocks.
456
			 */
457
			if (block->dirty) {
458
				fibril_mutex_lock(&devcon->com_area_lock);
459
				memcpy(devcon->com_area, block->data,
460
				    block->size);
461
				rc = write_block(devcon, block->boff,
462
				    block->size);
463
				assert(rc == EOK);
464
				fibril_mutex_unlock(&devcon->com_area_lock);
465
			}
466
			/*
467
			 * Take the block out of the cache and free it.
468
			 */
469
			unsigned long key = block->boff;
470
			hash_table_remove(&cache->block_hash, &key, 1);
471
			free(block);
472
			free(block->data);
473
			cache->blocks_cached--;
474
			fibril_mutex_unlock(&cache->lock);
475
			return;
476
		}
477
		/*
478
		 * Put the block on the free list.
479
		 */
3543 jermar 480
		list_append(&block->free_link, &cache->free_head);
4572 svoboda 481
		if (cache->mode != CACHE_MODE_WB && block->dirty) {
4611 jermar 482
			fibril_mutex_lock(&devcon->com_area_lock);
4583 svoboda 483
			memcpy(devcon->com_area, block->data, block->size);
484
			rc = write_block(devcon, block->boff, block->size);
4572 svoboda 485
			assert(rc == EOK);
4611 jermar 486
			fibril_mutex_unlock(&devcon->com_area_lock);
4572 svoboda 487
 
488
			block->dirty = false;
489
		}
3543 jermar 490
	}
4553 jermar 491
	fibril_mutex_unlock(&block->lock);
492
	fibril_mutex_unlock(&cache->lock);
3543 jermar 493
}
494
 
4583 svoboda 495
/** Read sequential data from a block device.
3543 jermar 496
 *
497
 * @param dev_handle	Device handle of the block device.
498
 * @param bufpos	Pointer to the first unread valid offset within the
499
 * 			communication buffer.
500
 * @param buflen	Pointer to the number of unread bytes that are ready in
501
 * 			the communication buffer.
502
 * @param pos		Device position to be read.
503
 * @param dst		Destination buffer.
504
 * @param size		Size of the destination buffer.
505
 * @param block_size	Block size to be used for the transfer.
506
 *
507
 * @return		EOK on success or a negative return code on failure.
508
 */
4583 svoboda 509
int block_seqread(dev_handle_t dev_handle, off_t *bufpos, size_t *buflen,
510
    off_t *pos, void *dst, size_t size, size_t block_size)
3543 jermar 511
{
512
	off_t offset = 0;
513
	size_t left = size;
514
	devcon_t *devcon = devcon_search(dev_handle);
515
	assert(devcon);
3540 jermar 516
 
4611 jermar 517
	fibril_mutex_lock(&devcon->com_area_lock);
3543 jermar 518
	while (left > 0) {
519
		size_t rd;
520
 
521
		if (*bufpos + left < *buflen)
522
			rd = left;
523
		else
524
			rd = *buflen - *bufpos;
525
 
526
		if (rd > 0) {
527
			/*
528
			 * Copy the contents of the communication buffer to the
529
			 * destination buffer.
530
			 */
531
			memcpy(dst + offset, devcon->com_area + *bufpos, rd);
532
			offset += rd;
533
			*bufpos += rd;
534
			*pos += rd;
535
			left -= rd;
536
		}
537
 
4549 svoboda 538
		if (*bufpos == (off_t) *buflen) {
3543 jermar 539
			/* Refill the communication buffer with a new block. */
4583 svoboda 540
			int rc;
541
 
542
			rc = read_block(devcon, *pos / block_size, block_size);
4611 jermar 543
			if (rc != EOK) {
544
				fibril_mutex_unlock(&devcon->com_area_lock);
4583 svoboda 545
				return rc;
4611 jermar 546
			}
3543 jermar 547
 
548
			*bufpos = 0;
549
			*buflen = block_size;
550
		}
551
	}
4611 jermar 552
	fibril_mutex_unlock(&devcon->com_area_lock);
3543 jermar 553
 
554
	return EOK;
3521 jermar 555
}
556
 
4583 svoboda 557
/** Read block from block device.
558
 *
559
 * @param devcon	Device connection.
560
 * @param boff		Block index.
561
 * @param block_size	Block size.
562
 * @param src		Buffer for storing the data.
563
 *
564
 * @return		EOK on success or negative error code on failure.
565
 */
566
static int read_block(devcon_t *devcon, bn_t boff, size_t block_size)
567
{
568
	ipcarg_t retval;
569
	int rc;
570
 
571
	assert(devcon);
572
	rc = async_req_2_1(devcon->dev_phone, BD_READ_BLOCK, boff, block_size,
573
	    &retval);
574
	if ((rc != EOK) || (retval != EOK))
575
		return (rc != EOK ? rc : (int) retval);
576
 
577
	return EOK;
578
}
579
 
4572 svoboda 580
/** Write block to block device.
581
 *
582
 * @param devcon	Device connection.
583
 * @param boff		Block index.
584
 * @param block_size	Block size.
585
 * @param src		Buffer containing the data to write.
586
 *
587
 * @return		EOK on success or negative error code on failure.
588
 */
4583 svoboda 589
static int write_block(devcon_t *devcon, bn_t boff, size_t block_size)
4572 svoboda 590
{
591
	ipcarg_t retval;
592
	int rc;
593
 
594
	assert(devcon);
4583 svoboda 595
	rc = async_req_2_1(devcon->dev_phone, BD_WRITE_BLOCK, boff, block_size,
596
	    &retval);
4572 svoboda 597
	if ((rc != EOK) || (retval != EOK))
598
		return (rc != EOK ? rc : (int) retval);
599
 
600
	return EOK;
601
}
602
 
3521 jermar 603
/** @}
604
 */